-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: Update cy.press signature to be Chainable #31698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since it's added via `Commands.add`, I believe `cy.press` should have a return type of `Chainable<null>` rather than `void`
Updated test for chainable
cypress
|
Project |
cypress
|
Branch Review |
update-cy.press-types
|
Run status |
|
Run duration | 19m 03s |
Commit |
|
Committer | Tim Griesser |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
1
|
|
9
|
|
1232
|
|
0
|
|
32158
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.83%
|
|
---|---|
|
190
|
|
165
|
Accessibility
92.73%
|
|
---|---|
|
3 critical
9 serious
2 moderate
2 minor
|
|
698
|
Tests for review
cypress/e2e/e2e/origin/cookie_login.cy.ts • 1 failed test • 5x-driver-cdp-firefox
@tgriesser A type error in the implementation is showing up on check-ts:
|
@jennifer-shehane should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgriesser Our unit tests are now failing due to this change: https://app.circleci.com/pipelines/github/cypress-io/cypress/70610/workflows/738e0034-f8a1-405b-890e-7782eaf14764/jobs/2899845
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Since it's added via
Commands.add
, I believecy.press
should have a return type ofChainable<null>
rather thanvoid
Additional details
Steps to test
Tests should pass